feat: add optional size property to Resource with builder #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @LucaButBoring , It looks good. |
|
Updated |
tzolov
pushed a commit
that referenced
this pull request
Jun 24, 2025
The size field helps hosts display file sizes and estimate context window usage. - Add size parameter to Resource record for tracking raw content size in bytes - Implement Builder pattern for Resource construction with validation - Add deprecated constructor for backwards compatibility - Add tests for builder pattern and field validation Resolves #330 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
|
Thanks @LucaButBoring , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional
sizeproperty to theResourcetype, which was added to the spec in 2025-03-26. Also adds aResourcebuilder class to avoid needing to add more constructors in the future.Motivation and Context
Missing spec-defined feature.
How Has This Been Tested?
Unit tests
Breaking Changes
None, added a backwards-compatible ctor to avoid a breaking change. Also implemented a builder to avoid needing to do this in the future.
Types of changes
Checklist
Additional context
Closes #330